New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nx.config
dict for configuring dispatching and backends
#7225
Merged
Merged
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
52f96fe
Add `nx.backend_config` dict for configuring dispatching and backends
eriknw 023c47f
Merge branch 'main' into backend_config
eriknw 0510588
Rename `nx.backend_config` to `nx.config`
eriknw ee437ad
Merge branch 'main' into backend_config
eriknw 93ba39e
"fallback_to_nx" is for testing, not for user config
eriknw 276a371
Merge branch 'main' into backend_config
eriknw dc8366a
Move config of backends to e.g. `nx.config["backends"]["cugraph"]`
eriknw 438c83a
How do you like this mypy?!
eriknw 9980f6a
Merge branch 'main' into backend_config
eriknw ba886c7
Rename `automatic_backends` to `backend_priority` (and env variables)
eriknw 40a27a7
Merge branch 'main' into backend_config
eriknw ae480b2
Merge branch 'main' into backend_config
eriknw c81595e
Create a class to handle configuration
eriknw c4b7892
Oops thanks mypy
eriknw 65c8583
Fix to work with more strict config
eriknw dd0096e
Support (and test) default values
eriknw eb7ea72
Merge branch 'main' into backend_config
eriknw 2323189
Remove `__class_getitem__` and add docstring
eriknw f45b1d2
Allow `strict=False` when defining subclasses.
eriknw 71d37e7
Move `__init_subclass__`
eriknw File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be for a separate PR but I think the config entry "automatic backends" could be named better (same for the corresponding env var), especially when seen next to the config entry here for "backends".
We should discuss this a bit more, but I think "backend priority" (
config["backend_priority"]
,NETWORKX_BACKEND_PRIORITY
) would be a better name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good thing to discuss 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think maybe we can think a bit more about the schema for the config dictionary, but for now let's go with this!