mge-hid.c: extend mge_model_names[] for Eaton 5SC and 5PX series
#2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
enhancement
need testing
arnaudquette-eaton
approved these changes
May 14, 2024
|
Just confirming here as well that this looks good on my 5PX 1500. I can now see values for battery.voltage and battery.voltage.nominal. |
…and 5PX series [networkupstools#2380] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2380
Testing needed, CC @jstallard @lemeshovich
Confirmation that the added device names/models are what should be expected from hardware would be very welcome - CC @arnaudquette-eaton
Here so far I've added the basic VA numbers from model lists for 5PX and 5SC, but there are many models marketed for some of the same power ratings - no idea if they identify differently via USB.
Also note that original 5PX is discontinued; not sure if 5PX Gen2 should identify differently (and/or if it needs another "type" enum value).