(closed) Fix cases where Connection Establishment Timed Out is incorrectly logged (1.6.x) (SimplePool) #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 25, 2024 21:43
…e statuses (only WAITING means a timeout). Also update to use new custom exceptions
|
@stevehu hi steve - can u reopen this PR? I replaced the PR branch which seems to have caused the PR to be auto-closed. thx |
|
The Reopen button is greyed out for me. I think the underline branch is gone so we have to recreate the PR from the new replaced branch. |
|
@stevehu thx. i will recreate it |
miklish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2172
In SimpleUndertowConnectionMaker, it is possible that a connection failure can be mis-logged as a connection timeout.
This fix corrects this and also adds more details to the logs about the cause of connection failures.
NOTE:
because: