segregated getDefaultNode in utils #1005
Conversation
| import com.networknt.schema.JsonSchemaFactory; | ||
| import com.networknt.schema.JsonSchemaRef; | ||
| import com.networknt.schema.SpecVersion.VersionFlag; | ||
| public class DefaultTest { |
There was a problem hiding this comment.
Rename to DefaultsTest.
| public class DefaultTest { | ||
|
|
||
| @Test | ||
| void testGetDefaultNodeNotNull() throws Exception { |
There was a problem hiding this comment.
This test case is exactly the same as the testGetDefaultNodeEquals case you have so you should remove this. If you want you can move the assertNotNull here to that other test case, but I don't think that is needed.
You should test
- The behavior when the node cannot be found
- The behavior when there is a
$ref
There was a problem hiding this comment.
Still need the test for $ref
|
|
||
| public class Defaults { | ||
|
|
||
| public static JsonNode getDefaultNode(JsonSchema schema) { |
There was a problem hiding this comment.
Fix the formatting. There is additional spaces before public and add the javadoc for the method.
| import com.networknt.schema.JsonSchema; | ||
| import com.networknt.schema.JsonSchemaRef; | ||
|
|
||
| public class Defaults { |
There was a problem hiding this comment.
Add the javadoc for the class.
| * Note: This class requires the 'com.networknt.schema.JsonSchema' and | ||
| * 'com.networknt.schema.JsonSchemaRef' classes | ||
| * from the 'networknt/json-schema-validator' library. | ||
| */ |
There was a problem hiding this comment.
Just change this to The 'Defaults' class provides utility methods for retrieving default values from a JSON schema.
| @@ -31,4 +35,19 @@ void testGetDefaultNodeWhenDefaultNotFound() throws Exception { | |||
| // Assert that the result is null, as there's no "default" node in the schema | |||
| assertNull(result, "Default node should be null when 'default' node is not found in the schema"); | |||
| } | |||
|
|
|||
| @Test | |||
| void testGetDefaultNodeWhenDefaultInRef() throws Exception { | |||
There was a problem hiding this comment.
Don't create external resources for the test. Just use strings inline as it makes the test hard to read and verify. This test isn't even valid. You have a unused variable JsonNode mainSchemaNode.
Segregated
getDefaultNodemethod to the utlis package to avoid duplicate code in the class.