New algorithm: dynamic approx electrical closeness #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move test from CentralityGTest to new file
- approximating columns - returning a laplacian / lpinv vectors
allows us to make copy constructor = default
angriman
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Thank you for the PR. I see that this algorithm shares a lot of data structures and code with ApproxElectricalCloseness. I'd suggest declaring DynApproxElectricalCloseness as a subclass of ApproxElectricalCloseness, so that you can re-use existing code and avoid duplication.
| /** | ||
| * @note batch updates are not supported. | ||
| */ | ||
| void updateBatch([[maybe_unused]] const std::vector<GraphEvent> &batch) override { |
There was a problem hiding this comment.
Suggested change
| void updateBatch([[maybe_unused]] const std::vector<GraphEvent> &batch) override { | |
| void updateBatch(const std::vector<GraphEvent> &) override { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This algorithm is based on the
ApproxElectricalClosenessalgorithm in networkit.The dynamic algorithm supports:
This implementation currently does not support arbitrary edge deletions: edges on the BFS tree from the pivot element
u(which is used to approximate r(u,v) for allv) may not be deleted, because this would require a larger update computation. In principle, this is possible, but for my use case this is not a problem right now. The code can easily be extended when the need arises.Additional changes in this PR:
ApproxElectricalClosenessto a more accurate description of the results properties