-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method Selection::havingOr #243
base: master
Are you sure you want to change the base?
Conversation
30f8fa0
to
5d5ecea
Compare
Hello, David. Does this look good to you? I will eventually solve the currently present issues, I hope. I'm in a hurry now though. Sidenote: I spent unnecessary time to find out how to run the tests so that most of them are not skipped... May I suggest adding a brief info for other devs how to run the tests? |
Another sidenote: I was wondering why are the two methods ( |
Thanks, it looks great!
That would be great, I don't realize these things. Maybe add it to a the file
Unfortunately, I don't know, I'm not an author. It could be unified, but I don't know how big a BC break would be. |
f9fc19d
to
dd75e74
Compare
cce6a9c
to
7e705c5
Compare
9acf825
to
a268c60
Compare
a56e7fe
to
d9b5f29
Compare
f016c33
to
6596c77
Compare
a9e5763
to
c3cc31a
Compare
e91b234
to
953502b
Compare
f8de9c7
to
52d72e1
Compare
89f161f
to
b2e171f
Compare
893ffa2
to
4c9eb34
Compare
2f4eae7
to
b8686b9
Compare
ed576c5
to
e27cfc8
Compare
13dc813
to
61e494f
Compare
53f52b2
to
860a033
Compare
458832d
to
c328e2c
Compare
havingOr
? #240)Adds
Selection::havingOr
method analogously to theSelection::whereOr
, refactoring the common logic into a separate protected method (Selection::paramsOr
).closes #240