-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlBuilder: Fixed joinWhere with aliases and .tables #141
Open
senasi
wants to merge
3
commits into
nette:master
Choose a base branch
from
senasi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
? [$table => $this->parameters['joinCondition'][$this->reservedTableNames[$table]]] | ||
: []; | ||
|
||
if (array_key_exists($table, $this->aliases)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is needed array_key_exist? isset($this->aliases[$table])
is faster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @senasi
dg
force-pushed
the
master
branch
13 times, most recently
from
October 18, 2016 13:01
44a230d
to
829b936
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
December 3, 2016 18:55
b74e9fb
to
b2e321a
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
January 4, 2017 14:15
e249c62
to
d56890f
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
January 15, 2017 07:08
e95a595
to
0b4d2e5
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
October 10, 2023 16:59
89f161f
to
b2e171f
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
November 5, 2023 19:45
893ffa2
to
4c9eb34
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
December 8, 2023 11:17
2f4eae7
to
b8686b9
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
December 14, 2023 20:02
ed576c5
to
e27cfc8
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
May 2, 2024 10:40
13dc813
to
61e494f
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
May 13, 2024 16:16
53f52b2
to
860a033
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
May 16, 2024 14:01
458832d
to
c328e2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.