Skip to content

Conversation

@f22hd
Copy link
Contributor

@f22hd f22hd commented Oct 23, 2021

Thanks for contributing the Netlify plugins directory!

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Have you completed the following?

Test plan
Please add a link to a successful public deploy log using the stated version of the plugin. Include any other context reviewers might need for testing.

Testing info:

@netlify-bot
Copy link
Collaborator

@f22hd f22hd force-pushed the add-nx-skip-deploy branch from 3d10837 to 9502ed3 Compare October 23, 2021 00:02
@f22hd f22hd changed the title add nx skip deploy plugin feat: add nx skip deploy plugin Oct 23, 2021
@ehmicky ehmicky self-requested a review October 25, 2021 15:50
@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 25, 2021
@ehmicky
Copy link
Contributor

ehmicky commented Oct 25, 2021

Thanks a lot for this plugin @f22hd!

I have added some small comments as issues in the repository. Please let me know what you think!

Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
@f22hd f22hd requested a review from ehmicky October 26, 2021 14:26
@ehmicky
Copy link
Contributor

ehmicky commented Oct 26, 2021

Thanks @f22hd.
Please let me know what you think on the GitHub issues posted above.
Looking forward to integrate this plugin 👍

@f22hd
Copy link
Contributor Author

f22hd commented Oct 26, 2021

@ehmicky
Thanks for your feedback,
I posted PR's to resolve the issues.

@f22hd
Copy link
Contributor Author

f22hd commented Oct 28, 2021

@ehmicky thanks for your valued inputs.
I've been closed all issues you mention.

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot @f22hd

f22hd and others added 2 commits October 29, 2021 16:35
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
@ehmicky ehmicky merged commit 8197120 into netlify:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature code contributing to the implementation of a feature and/or user facing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants