-
Notifications
You must be signed in to change notification settings - Fork 67
feat: add netlify-plugin-use-env-in-runtime
#403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This plugin allows you to transfer environment variables in the runtime of your application from those declared in your netlify.toml file and which are only executed at build time. You can even override variables defined in the Netlify UI!
|
Hi @ARKHN3B! Thanks for submitting your plugin. As per our Plugin Author Guidelines, plugins must provide a zero-config default if they are to be installable via the UI. This includes not relying on required inputs, which your plugin seems to do. Can you change it so that you're able to provide a zero-config default? |
|
Thanks a lot for this plugin @ARKHN3B! This is a great idea. One popular Build plugin What are your thoughts on adding that feature to this existing plugin instead? For example, you could add a |
Thank you for the suggestion @ehmicky! I think this changes the philosophy of this plugin a bit. But I'm 💯 up for collaborating on this project and adding this logic on it. I will work on it and submit a PR soon 🙂 |
|
Thanks @ARKHN3B! |
Thank you for your response @eduardoboucas! I've been working on it and I think my plugin fits Netlify's requirements now 🙂 |
netlify-plugin-use-env-in-runtime
|
Thanks for your patience @ARKHN3B! |
Thanks to you @ehmicky ! 💯 Good comments, thank you for the time you used to review my code. It's always good to have an external feedback. 🙂 I've had time to implement your feedback, it should be fine now. |
ehmicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ARKHN3B! 🎉
Description:
This plugin allows you to transfer environment variables in the runtime of your application from those declared in your netlify.toml file and which are only executed at build time.
You can even override variables defined in the Netlify UI!
Thanks for contributing the Netlify plugins directory!
Are you adding a plugin or updating one?
Have you completed the following?
Test plan
Please add a link to a successful public deploy log using the stated version of the plugin. Include any other context reviewers might need for testing.
For test plan, see: https://app.netlify.com/sites/use-env-in-runtime-plugin-demo/deploys/6106f295e858e60008be2c41