Skip to content
This repository was archived by the owner on Oct 10, 2022. It is now read-only.

Conversation

tzmanics
Copy link
Contributor

@tzmanics tzmanics commented Jan 7, 2021

- Summary

For the authorization example in the README.md, switches out the use of the openBrowser function to the open library as suggested by @ehmicky. This makes the example a little more encapsulated.

- A picture of a cute animal (not mandatory but encouraged)
main-qimg-0ed1eb8b029f487633cce500ceac79fa

@tzmanics tzmanics added the type: chore work needed to keep the product and development running smoothly label Jan 7, 2021
@tzmanics tzmanics requested review from ehmicky and erezrokah January 7, 2021 07:12
@tzmanics tzmanics self-assigned this Jan 7, 2021
I just realized this part wasn't aligned with the example code above it.
@tzmanics
Copy link
Contributor Author

tzmanics commented Jan 8, 2021

Hi @erezrokah thanks for the 👍, on further review, I saw another fix in changing api to client to match the other example code in the readme. Sorry for the change, hope it's ok!

@erezrokah
Copy link
Contributor

Hi @erezrokah thanks for the 👍, on further review, I saw another fix in changing api to client to match the other example code in the readme. Sorry for the change, hope it's ok!

This is great, thank you for following up with that fix :)

@erezrokah
Copy link
Contributor

erezrokah commented Jan 11, 2021

@tzmanics I changed the required checks per #271
Let me know when you're ready and I can merge this one (or you can wait for #271 and rebase).

Update

We're postponing #271

@tzmanics
Copy link
Contributor Author

I think it's good to merge this one now and I can re-check after #271 is merged. THanks!

@erezrokah erezrokah merged commit 30da76b into master Jan 11, 2021
@erezrokah erezrokah deleted the tzm/useDifferentBrowserExample branch January 11, 2021 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants