Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added TS to open-browser file #6574

Merged
merged 1 commit into from May 10, 2024

Conversation

HannahThor
Copy link
Contributor

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Added TS to open-browser file. I couldn't find any @types/open-browser package in the DefinitelyTyped repo, so left the @ts-expect-error.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@HannahThor HannahThor requested a review from a team as a code owner May 9, 2024 20:59
Copy link

github-actions bot commented May 9, 2024

πŸ“Š Benchmark results

Comparing with a79430f

  • Dependency count: 1,347 (no change)
  • Package size: 312 MB ⬇️ 0.00% decrease vs. a79430f
  • Number of ts-expect-error directives: 993 ⬇️ 0.30% decrease vs. a79430f

@khendrikse
Copy link
Contributor

This is awesome! Thank you so much for doing this :)

@khendrikse khendrikse merged commit d13cb53 into netlify:main May 10, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants