chore(deps): update actions/upload-artifact action to v4 #6569
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
📊 Benchmark resultsComparing with b2d35aa
|
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/major-github-artifact-actions
branch
from
dcc9148
to
3ae9fec
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
mrstork
force-pushed
the
renovate/major-github-artifact-actions
branch
from
934bf25
to
06dff5d
Compare
mrstork
force-pushed
the
renovate/major-github-artifact-actions
branch
from
06dff5d
to
915816d
Compare
mrstork
force-pushed
the
renovate/major-github-artifact-actions
branch
from
915816d
to
dcb34fb
Compare
mrstork
force-pushed
the
renovate/major-github-artifact-actions
branch
from
dcb34fb
to
494d8f2
Compare
mrstork
force-pushed
the
renovate/major-github-artifact-actions
branch
from
494d8f2
to
9d5fc57
Compare
mrstork
force-pushed
the
renovate/major-github-artifact-actions
branch
from
9d5fc57
to
56b84d0
Compare
mrstork
force-pushed
the
renovate/major-github-artifact-actions
branch
from
56b84d0
to
a4134fe
Compare
mrstork
force-pushed
the
renovate/major-github-artifact-actions
branch
from
69b3b44
to
b869c7f
Compare
|
|
||
| - name: Sanitize shard for artefact name | ||
| id: sanitize-shard-name | ||
| run: echo "shard=$(echo '${{ matrix.shard }}' | tr '/' '-')" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
GitHub doesn't allow / in the file name (see L116)
| path: | | ||
| /home/runner/.npm/_logs/**/* | ||
|
|
||
| - uses: codecov/codecov-action@v4 | ||
| continue-on-error: true | ||
| with: | ||
| flags: ${{ steps.test-coverage-flags.outputs.os }},${{ steps.test-coverage-flags.outputs.node }} | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
This is currently not being picked up, could we make sure it hasn't accidentally been removed? (I don't have permissions to view)
There was a problem hiding this comment.
I don't think this secret has ever existed - I think this PR is trying to tell us that we need one now with the newest version?
There was a problem hiding this comment.
Do we have an account for https://app.codecov.io/gh/netlify/cli? Can we retrieve a token from that account? Otherwise I can downgrade us back to codecov/codecov-action@v3 (where the token isn't required for the workflow step). There might be a case to be made for removing the codecov step completely as it doesn't seem to be very depended on, though you folks would have more context on that topic.
This PR contains the following updates:
v3->v4Release Notes
actions/upload-artifact (actions/upload-artifact)
v4Compare Source
Configuration
📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.