Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect excludedPattern defined in netlify.toml #6533

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Apr 26, 2024

Title says it all! We were only looking at the per-function setting for this, not at the per-route setting. This PR fixes that.

@Skn0tt Skn0tt self-assigned this Apr 26, 2024
@Skn0tt Skn0tt requested a review from a team as a code owner April 26, 2024 15:00
@Skn0tt Skn0tt marked this pull request as draft April 26, 2024 15:01
Copy link

github-actions bot commented Apr 26, 2024

📊 Benchmark results

Comparing with 9eab9f4

  • Dependency count: 1,347 (no change)
  • Package size: 312 MB ⬇️ 0.00% decrease vs. 9eab9f4
  • Number of ts-expect-error directives: 997 (no change)

@Skn0tt Skn0tt changed the title chore: repro for excludedPattern not working for edge functions when defined in netlify.toml fix: respect both per-function and per-route excludedPattern for edge functions May 2, 2024
@Skn0tt Skn0tt changed the title fix: respect both per-function and per-route excludedPattern for edge functions fix: respect excludedPattern defined in netlify.toml May 2, 2024
@Skn0tt Skn0tt marked this pull request as ready for review May 2, 2024 08:34
@Skn0tt
Copy link
Member Author

Skn0tt commented May 2, 2024

The test failures seem unrelated to me.

@lemusthelroy
Copy link
Contributor

lemusthelroy commented May 2, 2024

We are working on the test failures. Will update you when this is resolved. #6542

@sarahetter sarahetter removed the request for review from a team May 2, 2024 12:23
@Skn0tt Skn0tt enabled auto-merge (squash) May 3, 2024 08:52
@Skn0tt Skn0tt merged commit 1729ef0 into main May 9, 2024
48 checks passed
@Skn0tt Skn0tt deleted the simonknott/com-663-excludepath-not-being-respected-when-declared-in-toml-file branch May 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants