Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add types to gitignore.ts #6527

Merged
merged 6 commits into from May 2, 2024

Conversation

HannahThor
Copy link
Contributor

@HannahThor HannahThor commented Apr 23, 2024

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Add types for gitignore.ts file


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@HannahThor HannahThor requested a review from a team as a code owner April 23, 2024 21:02
Copy link

github-actions bot commented Apr 24, 2024

πŸ“Š Benchmark results

Comparing with 9e4b616

  • Dependency count: 1,329 (no change)
  • Package size: 310 MB (no change)
  • Number of ts-expect-error directives: 997 ⬇️ 0.40% decrease vs. 9e4b616

Copy link
Contributor

@sarahetter sarahetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hannah! This looks good to me, thank you! We've got some tests failing for external contributors that'll block me merging this until we work out what's going on there, but I'll keep an eye on it and merge when ready.

@lemusthelroy lemusthelroy enabled auto-merge (squash) May 2, 2024 15:06
@lemusthelroy lemusthelroy merged commit 407d246 into netlify:main May 2, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants