Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove skipWaitPort from help and docs #6478

Merged
merged 5 commits into from Mar 27, 2024
Merged

fix: remove skipWaitPort from help and docs #6478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ebd214e
feat: allow skipping the target port wait
davbree Mar 26, 2024
56cb18e
fix: sync docs
davbree Mar 26, 2024
8a8c57c
fix: remove skipWaitPort from help and docs
davbree Mar 27, 2024
bf670c7
chore: merge
davbree Mar 27, 2024
9961f37
fix: sync docs
davbree Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/commands/dev.md
View file
Open in desktop
Expand Up @@ -32,7 +32,6 @@ netlify dev
- `no-open` (*boolean*) - disables the automatic opening of a browser window
- `offline` (*boolean*) - disables any features that require network access
- `port` (*string*) - port of netlify dev
- `skip-wait-port` (*boolean*) - disables waiting for target port to become available
- `target-port` (*string*) - port of target app server
- `debug` (*boolean*) - Print debugging information

Expand Down
2 changes: 1 addition & 1 deletion src/commands/dev/dev.ts
View file
Open in desktop
Expand Up @@ -264,7 +264,7 @@ export const createDevCommand = (program: BaseCommand) => {
.argParser((value) => Number.parseInt(value))
.hideHelp(true),
)
.option('--skip-wait-port', 'disables waiting for target port to become available')
.addOption(new Option('--skip-wait-port', 'disables waiting for target port to become available').hideHelp(true))
.addOption(new Option('--no-open', 'disables the automatic opening of a browser window'))
.option('--target-port <port>', 'port of target app server', (value) => Number.parseInt(value))
.option('--framework <name>', 'framework to use. Defaults to #auto which automatically detects a framework')
Expand Down