fix: broken deploy with --skip-functions-cache #6433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the getPathInProject function is not monorepo aware this breaks on monorepos
lukasholzer
commented
Mar 13, 2024
| @@ -42,6 +42,7 @@ module.exports = { | |||
| 'unicorn/consistent-destructuring': 0, | |||
| // TODO: harmonize with filename snake_case in other Netlify Dev projects | |||
| 'unicorn/filename-case': [2, { case: 'kebabCase' }], | |||
| 'max-params': 'off', | |||
There was a problem hiding this comment.
just useless this linting rule
eduardoboucas
previously approved these changes
Mar 13, 2024
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
eduardoboucas
previously approved these changes
Mar 13, 2024
eduardoboucas
approved these changes
Mar 13, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes broken deploys when run with
ntl deploy --build --skip-functions-cacheinside monorepos.As the
getPathInProjectfunction is not monorepo aware, this breaks on monorepos.There are more areas that depend on this function, but I'll do this in follow-up PRs to keep the PR size small.
Fixes https://linear.app/netlify/issue/FRA-385/could-not-resolve-vartaskappsdocsnetlifydistrunhandlerstracingjs
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)