fix: pass api host to @netlify/build #6424
Conversation
📊 Benchmark resultsComparing with b4d8fec
|
src/utils/run-build.ts
Outdated
| @@ -66,6 +66,7 @@ export const runNetlifyBuild = async ({ command, env = {}, options, settings, ti | |||
| configPath: cachedConfig.configPath, | |||
| siteId: cachedConfig.siteInfo.id, | |||
| token: cachedConfig.token, | |||
| host: apiOpts.host, | |||
There was a problem hiding this comment.
Isn't the property called apiHost instead of host? https://github.com/netlify/build/blob/2d10996ee91e7640be0e4b53105ae30cb42752fe/packages/build/src/core/normalize_flags.ts#L94
Also, we're already doing something similar here. I understand these are currently different entry points into @netlify/build, but it'd be nice to at least standardise the way we pass these properties so it's easier for us to consolidate things into a single entry point in the future.
There was a problem hiding this comment.
good catch, not sure what happened there!
There was a problem hiding this comment.
re standardization - apiOpts seemed like the best way because it's defined in base-command, but open for suggestions 😄
If API host is configured to staging, currently CLI will use that but
@netlify/buildwill use production.To fix this we need to pass in the configured host to
@netlify/build.