Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle empty store on blobs:list #6420

Merged
merged 3 commits into from Mar 8, 2024
Merged

fix: handle empty store on blobs:list #6420

merged 3 commits into from Mar 8, 2024

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas commented Mar 7, 2024 •
edited by mraerino

Summary

Gracefully handles the case of an empty store in the blobs:list command.

Before

Screenshot 2024-03-07 at 16 07 46

After

Screenshot 2024-03-07 at 16 07 51

Closes COM-302

@eduardoboucas eduardoboucas requested a review from a team as a code owner March 7, 2024 17:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024 •
edited

📊 Benchmark results

Comparing with ead8cf1

  • Dependency count: 1,328 (no change)
  • Package size: 305 MB ⬇️ 0.00% decrease vs. ead8cf1
  • Number of ts-expect-error directives: 1,179 (no change)

ascorbic
ascorbic approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Q of my L is increasing

@charliegroll
Copy link
Member

I personally prefer the Before image, but to each their own

@eduardoboucas eduardoboucas enabled auto-merge (squash) March 8, 2024 10:15
@eduardoboucas eduardoboucas merged commit 726745a into main Mar 8, 2024
40 checks passed
@eduardoboucas eduardoboucas deleted the fix/blobs-list-empty branch March 8, 2024 10:30
@token-generator-app token-generator-app bot mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eduardoboucas @charliegroll @ascorbic