Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce env var to include dev server plugin #6410

Merged
merged 4 commits into from Mar 5, 2024
Merged

Conversation

davbree
Copy link
Contributor

@davbree davbree commented Mar 4, 2024

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Fixes #<replace_with_issue_number>


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@davbree davbree requested a review from a team as a code owner March 4, 2024 06:39
Copy link

github-actions bot commented Mar 4, 2024

πŸ“Š Benchmark results

Comparing with de0942a

  • Dependency count: 1,295 (no change)
  • Package size: 284 MB ⬇️ 0.00% decrease vs. de0942a
  • Number of ts-expect-error directives: 1,180 (no change)

@@ -137,6 +137,11 @@ export const dev = async (options: OptionValues, command: BaseCommand) => {
try {
settings = await detectServerSettings(devConfig, options, command)

if (process.env.NETLIFY_INCLUDE_DEV_SERVER_PLUGIN) {
log(`${NETLIFYDEVLOG} Including dev server plugin`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the customer-facing name we're going with? And is there value in showing this message? I believe we'll still show a generic message from Netlify Build indicating that this plugin is being loaded? I would consider printing this only if debug is true.

@davbree davbree enabled auto-merge (squash) March 5, 2024 12:44
@davbree davbree merged commit 31e2abf into main Mar 5, 2024
36 checks passed
@davbree davbree deleted the plugin-dev-server branch March 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants