Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not prompt for project if --cwd was provided #6362

Merged
merged 3 commits into from May 2, 2024

Conversation

zregvart
Copy link
Contributor

Summary

Fixes #5977

The prompt for selecting the site to work with in a project with multiple workspaces breaks CI workflows that are non-interactive. The proposed solution in providing --cwd does not help as the selection is triggered regardless of providing the --cwd. This fixes that so that the selection of project is not prompted if --cwd flag is provided.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

hedgehog-1630030_640

Copy link

github-actions bot commented Mar 18, 2024

πŸ“Š Benchmark results

Comparing with 0d2a7db

  • Dependency count: 1,329 (no change)
  • Package size: 310 MB (no change)
  • Number of ts-expect-error directives: 997 (no change)

@sarahetter sarahetter removed the request for review from a team April 23, 2024 16:03
@sarahetter sarahetter merged commit 7e13196 into netlify:main May 2, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing with "We've detected multiple sites inside your repository"
3 participants