feat: populate Blobs context in build plugins #5571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Apr 2, 2024
| @@ -26,12 +26,12 @@ const setTimeoutPromise = promisify(setTimeout) | |||
| // response: json payload response (defaults to {}) | |||
| // status: http status code (defaults to 200) | |||
| // wait: number used to induce a certain time delay in milliseconds in the response (defaults to undefined) | |||
| export const startServer = async (handler: ServerHandler) => { | |||
| export const startServer = async (handler: ServerHandler, port = 0) => { | |||
There was a problem hiding this comment.
Sometimes it's useful to know the port before starting the server, so this makes it possible for the consumer to specify the port that the server should use.
|
This pull request adds or modifies JavaScript ( |
mrstork
reviewed
Apr 4, 2024
mrstork
reviewed
Apr 4, 2024
| token?: string | ||
| } | ||
|
|
||
| // TODO: Move this work to a method exported by `@netlify/blobs`. |
There was a problem hiding this comment.
Something I've done in the past is attach a ticket number to TODO comments. This helps ensures that the work gets finished, gives a space to provide more detailed context, and makes it easier for other people to pick up the work.
mrstork
reviewed
Apr 4, 2024
| [ | ||
| { | ||
| response: { url: `http://localhost:${serverPort}/some-signed-url` }, | ||
| path: `/api/v1/blobs/${siteId}/deploy:${deployId}/my-key`, |
There was a problem hiding this comment.
Maybe we should we have a test with region included as well?
mrstork
reviewed
Apr 4, 2024
mrstork
previously approved these changes
Apr 4, 2024
mrstork
previously approved these changes
Apr 10, 2024
mrstork
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Populates the Blobs context in the build plugins execution environment, so that build plugins can interact with Blobs without having to initialise the client with access credentials and API addresses. It makes the experience consistent with the functions and edge functions entry points.
Closes COM-542.