fix: stop pinning plugins with prerelease versions #5554
Merged
+123
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
ascorbic
reviewed
Mar 21, 2024
packages/build/src/utils/semver.js
Outdated
| export const isPrerelease = function (version) { | ||
| // Prerelease versions are excluded from ranges unless `includePrerelease` is | ||
| // set to `true`. | ||
| return !semver.satisfies(version, '>=0.0.0', { includePrerelease: false }) |
There was a problem hiding this comment.
Could you use semver.prerelease()?
There was a problem hiding this comment.
You prefer a simpler and more expressive method? FINE, whatever.
(This method is not in the docs, so I had to get creative. Thanks!)
Done in adc65d4.
lukasholzer
previously approved these changes
Mar 21, 2024
ascorbic
previously approved these changes
Mar 21, 2024
eduardoboucas
dismissed stale reviews from ascorbic and lukasholzer
via
2701063
lukasholzer
approved these changes
Mar 21, 2024
Merged
ascorbic
reviewed
Mar 21, 2024
Comment on lines
-14
to
-15
| [0m[31m[1m>[22m[39m[90m 1 |[39m [32m"json"[39m[0m␊ | ||
| [0m [90m |[39m [31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m [31m[1m👈🏽 [95mtype[31m must be object[22m[39m[0m` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes COM-566.