Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable test in Node 14 #5550

Merged
merged 5 commits into from Mar 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 18 additions & 14 deletions packages/build/tests/deploy_config/tests.js
@@ -1,8 +1,9 @@
import { promises as fs } from 'fs'
import { platform } from 'process'
import { platform, version as nodeVersion } from 'process'

import { Fixture } from '@netlify/testing'
import test from 'ava'
import semver from 'semver'
import tmp from 'tmp-promise'

test('Does not mutate read-only properties', async (t) => {
Expand Down Expand Up @@ -43,21 +44,24 @@ test('Loads configuration data that has been generated by the build command', as
}
})

test('In a monorepo setup, loads package-specific configuration data', async (t) => {
const fixture = await new Fixture('./fixtures/monorepo').withCopyRoot({ git: false })
const { success, netlifyConfig } = await fixture
.withFlags({
cwd: fixture.repositoryRoot,
featureFlags: { netlify_build_deploy_configuration_api: true },
packagePath: 'apps/app-1',
})
.runBuildProgrammatic()
// pnpm is not available in Node 14.
if (semver.gte(nodeVersion, '16.9.0')) {
test('In a monorepo setup, loads package-specific configuration data', async (t) => {
const fixture = await new Fixture('./fixtures/monorepo').withCopyRoot({ git: false })
const { success, netlifyConfig } = await fixture
.withFlags({
cwd: fixture.repositoryRoot,
featureFlags: { netlify_build_deploy_configuration_api: true },
packagePath: 'apps/app-1',
})
.runWithBuildAndIntrospect()

t.true(success)
t.deepEqual(netlifyConfig.images, {
remote_images: ['domain1.netlify', 'domain2.netlify'],
t.true(success)
t.deepEqual(netlifyConfig.images, {
remote_images: ['domain1.netlify', 'domain2.netlify'],
})
})
})
}

test('Configuration data is exposed to build plugins in the `onBuild` event', async (t) => {
const { netlifyConfig, success } = await new Fixture('./fixtures/with_build_plugin')
Expand Down