fix: omit duplicates from list of bundled functions #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
approved these changes
Nov 2, 2021
XhmikosR
reviewed
Jan 16, 2022
| @@ -21,7 +21,10 @@ const getRelativeFunctionMainFiles = async function ({ featureFlags, functionsSr | |||
|
|
|||
| const zisiFeatureFlags = getZisiFeatureFlags(featureFlags) | |||
| const functions = await listFunctions(functionsSrc, { featureFlags: zisiFeatureFlags }) | |||
| return functions.map(({ mainFile }) => relative(functionsSrc, mainFile)) | |||
| const dedupedFunctions = new Map(functions.map((func) => [func.name, func])) | |||
There was a problem hiding this comment.
Just wondering, any reason you are not going with Set? Set ensures no duplicates exist by design :)
There was a problem hiding this comment.
We might have different functions with the same name. By passing an array of entries to Map, we guarantee that the last function with the same name takes precedence, which is the order in which zip-it-and-ship-it outputs the files.
Does that answer the question?
There was a problem hiding this comment.
Yes, thanks for the explanation :)
|
@eduardoboucas What's the latest status of this PR? Should it be closed? |
|
Sorry, my bad. This fell between the cracks. I'm updating the branch and will merge this later today. |
ehmicky
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When printing the list of bundled functions, Netlify Build uses zip-it-and-ship-it's
listFunctionsmethod, which includes functions that have not been bundled due to a naming conflict (e.g. when bothfunction.jsandfunction.tsare found). Because of this, Netlify Build was incorrectly reporting that both functions were bundled, when in fact onlyfunction.jswas.This PR removes those duplicate functions from the list.
Fixes #3974.
A picture of a cute animal (not mandatory, but encouraged)