Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove usage of Node built-ins #154

Merged
merged 1 commit into from Mar 6, 2024
Merged

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Replaces any Node built-in modules with cross-runtime equivalents.

The exception is the local server, which is Node only.

@eduardoboucas eduardoboucas requested a review from a team as a code owner March 6, 2024 15:59
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 741225f
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/65e89301435a2a00088e6386
😎 Deploy Preview https://deploy-preview-154--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ascorbic
Copy link
Member

ascorbic commented Mar 6, 2024

I wonder if the server could be moved to a subpath?

@eduardoboucas
Copy link
Member Author

I wonder if the server could be moved to a subpath?

I think so, but I'd rather do that as a follow-up because I want to flag it as a breaking change.

@eduardoboucas eduardoboucas merged commit 3148833 into main Mar 6, 2024
15 checks passed
@eduardoboucas eduardoboucas deleted the feat/cross-runtime-env branch March 6, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants