feat: allow internal access to legacy stores #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
mraerino
previously approved these changes
Mar 6, 2024
eduardoboucas
commented
Mar 6, 2024
| // HEAD requests are implemented directly in the Netlify API. | ||
| if (method === HTTPMethod.HEAD) { | ||
| // HEAD and DELETE requests are implemented directly in the Netlify API. | ||
| if (method === HTTPMethod.HEAD || method === HTTPMethod.DELETE) { |
There was a problem hiding this comment.
This is not exactly related to this PR, but I noticed this was wrong when tests started failing, so I'm including the fix here.
eduardoboucas
commented
Mar 6, 2024
| siteID, | ||
| storeName, | ||
| url, | ||
| if (legacyAPIURLMatch) { |
There was a problem hiding this comment.
We must continue supporting the legacy API endpoints because we might have an old client communicating with this server.
mraerino
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Allows site-scoped stores using the legacy namespace to be access using a special prefix. This is not a customer-facing feature and is meant to be used by Netlify tooling.
List other issues or pull requests related to this problem
Part of ADN-370.