Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add listStores method #149

Merged
merged 6 commits into from Mar 4, 2024
Merged

feat!: add listStores method #149

merged 6 commits into from Mar 4, 2024

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Adds a listStores method for listing site-scoped stores.

Please note that the internal logic for namespacing stores has changed, which means that any site-level stores that have been created using a previous version of the Netlify Blobs client will not be available in the new version. You can continue to use those stores with the previous client, but the data will not be accessible once you upgrade.

List other issues or pull requests related to this problem

Closes COM-454.

BREAKING CHANGE: Site-scoped created with previous versions of the client will not be accessible.
@eduardoboucas eduardoboucas requested a review from a team as a code owner March 4, 2024 12:49
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit b5c5bd4
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/65e5cf180f7f960008bddc4d
😎 Deploy Preview https://deploy-preview-149--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Skn0tt
Skn0tt previously approved these changes Mar 4, 2024
Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! left two code style remarks.

src/store_list.ts Outdated Show resolved Hide resolved
src/store_list.ts Outdated Show resolved Hide resolved
@eduardoboucas eduardoboucas merged commit 3d0a386 into main Mar 4, 2024
9 checks passed
@eduardoboucas eduardoboucas deleted the feat/list-stores branch March 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants