Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set new expiresat on each request #1815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apapazisis
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

The expiresAt field is not updated while new requests are sent.

Issue Number: N/A

What is the new behavior?

The expiresAt is updated on each request. That way we always calculate a new expiration time.
As an example if I have limit:2 and ttl: minutes(1) a bot which sends multiple requests will be blocked and as long as it continues to send requests will be blocked(429 error). The rate limit should go to 2 requests per minute to release the block(429 error).

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant