Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): introduce different module opaque key factories #13336

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Mar 18, 2024

Pull Request Test Coverage Report for Build 8992ffcb-4145-4cfe-b21d-217fd51a6835

Details

  • 44 of 46 (95.65%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 92.119%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/injector/compiler.ts 7 8 87.5%
packages/core/injector/container.ts 6 7 85.71%
Totals Coverage Status
Change from base Build 8e6acf8c-0eed-48d4-99cf-9df3f506aa5c: -0.05%
Covered Lines: 6744
Relevant Lines: 7321

💛 - Coveralls

Copy link
Contributor

@H4ad H4ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

packages/core/injector/compiler.ts Show resolved Hide resolved
packages/core/injector/compiler.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants