Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: virtual decorator #1350

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

LotfiMEZIANI
Copy link

@LotfiMEZIANI LotfiMEZIANI commented May 18, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1349

What is the new behavior?

Described here : #1349

Does this PR introduce a breaking change?

  • Yes
  • No

@kamilmysliwiec kamilmysliwiec mentioned this pull request May 19, 2022
1 task
@kamilmysliwiec
Copy link
Member

Can you add tests?

@LotfiMEZIANI LotfiMEZIANI force-pushed the feature/virtual-decorator branch 2 times, most recently from 75989b8 to 96410d4 Compare May 22, 2022 17:57
@LotfiMEZIANI
Copy link
Author

LotfiMEZIANI commented May 22, 2022

@kamilmysliwiec

Can you add tests?

It's done. But i don't know if I done it in the correct folder (tests/e2e).

@hartherbert
Copy link

Would love to see this get merged.

@bytesbay
Copy link

Any updates here?

Copy link

@bytesbay bytesbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear enough

@LotfiMEZIANI
Copy link
Author

@kamilmysliwiec, waiting for the merge, if everything is ok.

@KevinEdry
Copy link

@LotfiMEZIANI @kamilmysliwiec Any news on this? this should have merged by now...

@LotfiMEZIANI
Copy link
Author

@KevinEdry, for me it’s fine, I’m waiting for the validation of an owner of the repository (ping @kamilmysliwiec )

@graddaniel
Copy link

bump

I just happen to need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants