Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to overwrite event id strategy #1583

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Grzesie2k
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

We can change the way EventBus retrieves event IDs by extending this class and overriding EventBus.getEventId. However, if we do that, registered handlers will not be found because defaultReflectEventId is used in EventBus.registerHandler.

Issue Number: N/A

What is the new behavior?

We can change the way EventBus retrieves event IDs by assigning a different strategy to EventBus.eventIdProvider (similarly to EventBus.publisher), and there are no issues with registering handlers.

Does this PR introduce a breaking change?

  • Yes, but only in the case of an implementation that extended the eventBus class.
  • No

If you're extending the EventBus class in your code and relying on EventBus.getEventId, you should refactor the code to use this.eventIdProvider.getEventId instead.

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants