Remove units from spiking input ports #882
Conversation
the generated PyNestMLLexer.py
|
Thanks for all the work! I think we should stick to the original intention of the pull request, which was to remove units from spiking input ports. It is not clear at first glance what it means to have a unit next to an input port definition, so there is a high potential for mistakes. We should make it clear in the documentation that the units are 1/s, and the type checking system will take care of any potential inconsistencies. Unfortunately this will mean a little bit of extra syntax in the ODEs and convolutions where the units have to now be manually "multiplied in". |
doc/models_library/index.rst
Outdated
| @@ -1,386 +1,49 @@ | |||
| Models library | |||
| ============== | |||
|
|
|||
| Neuron models | |||
There was a problem hiding this comment.
This file still needs to be hand-tuned, unfortunately. Could you leave it as-is for this PR? We will pick it up again in #920.
| @@ -72,6 +74,23 @@ It is equivalent if either both `inhibitory` and `excitatory` are given, or neit | |||
| - ... should be negative. It is added to the buffer with non-negative magnitude :math:`-w`. | |||
|
|
|||
|
|
|||
| The incoming spikes at the spiking input port are modelled as Dirac delta function. The unit of the Dirac delta function follows from its definition | |||
|
|
|||
| .. math:: | |||
There was a problem hiding this comment.
I would expect the definition of the Dirac delta pulse here, given the previous sentence.
Fixes #727
This is based on #866 which should be merged first.