Fix compilation error when synapse model uses random_normal function
#805
Conversation
|
Note: #806 needs to be fixed before this is merged. |
| return tid; | ||
| } | ||
| {%- endif %} | ||
|
|
There was a problem hiding this comment.
Can't we just use kernel().vp_manager.get_thread_id() directly wherever this is needed? I'm not sure I like this additional indirection... Optimally, I think get_thread_id() should just be available as an API function in the nest namespace defined in nestkernel/nest.h in NEST Simulator proper.
There was a problem hiding this comment.
The generated code for the random_normal() function from NESTML is the same for both neurons and synapses. See here. The neuron already has an implementation of the get_thread() function in its base class whereas the synapse doesn't. Hence this PR adds a private implementation for the function.
There was a problem hiding this comment.
Should synapses instead use the thread t that is passed as a parameter to the send() method, rather than calling kernel().vp_manager.get_thread_id()? (cc @jougs)
|
This needs to be fixed from the NEST end. The corresponding issue in NEST: nest/nest-simulator#2902 |
Fixes #804
Unlike the neuron class, the synapse class in the generated code does not have an implementation of the
get_thread()function that is used innest::normal_distribution. This PR adds a private implementation of the function and returns the thread id from the NEST kernel.