Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shellcheck and pre-commit to CI jobs #3002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add shellcheck and pre-commit to CI jobs #3002

wants to merge 1 commit into from

Conversation

terhorstd
Copy link
Contributor

This is an addendum to #2880 adding a pre-commit run also to the CI pre-build checks.
The shellcheck is also added separately to address language specific linters on the same level.

Related PRs are:

@terhorstd terhorstd mentioned this pull request Nov 21, 2023
Open
@terhorstd terhorstd added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Nov 27, 2023
@terhorstd terhorstd added this to To do in Build system and CI via automation Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Build system and CI
  
To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@terhorstd