Merge branch 'v2' of github.com:nerdalize/nerd into v2

cmd/dataset_download.go

@@ -148,7 +148,9 @@ func (cmd *DatasetDownload) Execute(args []string) (err error) {
 			return errors.Wrap(err, "failed to download dataset")
 		}
 	}
-	if len(datasets) > 1 {
+	if len(datasets) == 0 {
+		cmd.out.Infof("No dataset found, maybe your job is not using any datasets? You can check with `nerd job list` the state of your job.")
+	} else if len(datasets) > 1 {
 		cmd.out.Infof("Downloaded %d datasets in %s", len(datasets), outputDir)
 	} else {
 		cmd.out.Infof("Downloaded %d dataset in %s", len(datasets), outputDir)

cmd/errors.go

@@ -45,7 +45,7 @@ func renderServiceError(err error, format string, args ...interface{}) error {
 	case kubevisor.IsKubernetesErr(err):
 		return errors.Errorf("%s: cluster failed to perform action: %v", fmt.Errorf(format, args...), err)
 	case kubevisor.IsAlreadyExistsErr(err):
-		return errors.Errorf("%s: it already exists", fmt.Errorf(format, args...))
+		return errors.Errorf("%s: this name is already in use", fmt.Errorf(format, args...))
 	case kubevisor.IsNamespaceNotExistsErr(err):
 		return errors.Errorf("%s: the namespace does not exist or you have no access. If the problem persists, please contact mayday@nerdalize.com.", fmt.Errorf(format, args...))
 	case kubevisor.IsServiceUnavailableErr(err):

svc/svc.go

@@ -42,7 +42,7 @@ type DI interface {
 //ErrMinikubeOnly is returned when a temp di is created on something thats not minikube
 var ErrMinikubeOnly = errors.New("temp DI can only be created on Minikube")
 
-//Derived from https://github.com/golang/go/blob/1106512db54fc2736c7a9a67dd553fc9e1fca742/src/path/filepath/path_unix.go#L12
+// ValidateAbsPath is derived from https://github.com/golang/go/blob/1106512db54fc2736c7a9a67dd553fc9e1fca742/src/path/filepath/path_unix.go#L12
 func ValidateAbsPath(fl validator.FieldLevel) bool {
 	return strings.HasPrefix(fl.Field().String(), "/")
 }