Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: refuse to run without remote storage #7722

Merged
merged 1 commit into from May 13, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented May 13, 2024

Problem

Since #6769, the pageserver is intentionally not usable without remote storage: it's purpose is to act as a cache to an object store, rather than as a source of truth in its own right.

Summary of changes

  • Make remote storage configuration mandatory: the pageserver will refuse to start if it is not provided.

This is a precursor that will make it safe to subsequently remove all the internal Option<>s

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels May 13, 2024
Copy link

3060 tests run: 2927 passed, 0 failed, 133 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_lock_time_tracing: debug

Code coverage* (full report)

  • functions: 31.4% (6330 of 20161 functions)
  • lines: 47.3% (47754 of 100969 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c6cf7db at 2024-05-13T10:19:55.408Z :recycle:

@jcsp jcsp marked this pull request as ready for review May 13, 2024 12:05
@jcsp jcsp requested a review from a team as a code owner May 13, 2024 12:05
@jcsp jcsp requested a review from VladLazar May 13, 2024 12:05
@jcsp jcsp merged commit f50ff14 into main May 13, 2024
59 checks passed
@jcsp jcsp deleted the jcsp/pageserver-mandatory-remote-storage branch May 13, 2024 12:05
jcsp added a commit that referenced this pull request May 15, 2024
…file refs (#7752)

## Problem

This is historical baggage from when the pageserver could be run with
local disk only: we had a bunch of places where we had to treat remote
storage as optional.

Closes: #6890

## Changes

- Remove Option<> around remote storage (in
#7722 we made remote storage
clearly mandatory)
- Remove code for deleting old metadata files: they're all gone now.
- Remove other references to metadata files when loading directories, as
none exist.

I checked last 14 days of logs for "found legacy metadata", there are no
instances.
a-masterov pushed a commit that referenced this pull request May 20, 2024
## Problem

Since #6769, the pageserver is
intentionally not usable without remote storage: it's purpose is to act
as a cache to an object store, rather than as a source of truth in its
own right.

## Summary of changes

- Make remote storage configuration mandatory: the pageserver will
refuse to start if it is not provided.

This is a precursor that will make it safe to subsequently remove all
the internal Option<>s
a-masterov pushed a commit that referenced this pull request May 20, 2024
…file refs (#7752)

## Problem

This is historical baggage from when the pageserver could be run with
local disk only: we had a bunch of places where we had to treat remote
storage as optional.

Closes: #6890

## Changes

- Remove Option<> around remote storage (in
#7722 we made remote storage
clearly mandatory)
- Remove code for deleting old metadata files: they're all gone now.
- Remove other references to metadata files when loading directories, as
none exist.

I checked last 14 days of logs for "found legacy metadata", there are no
instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants