Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: allow using allowed_errors.py #7719

Merged
merged 9 commits into from May 13, 2024
Merged

python: allow using allowed_errors.py #7719

merged 9 commits into from May 13, 2024

Conversation

koivunej
Copy link
Contributor

@koivunej koivunej commented May 13, 2024 •
edited

See #7718. Fix it by renaming all types.py to common_types.py.

Additionally, add an advert for using allowed_errors.py to test any added regex.

@koivunej koivunej force-pushed the joonas/allow_using_allowed_errors branch from a61fe48 to c072ace Compare May 13, 2024 08:52
@koivunej koivunej requested a review from jcsp May 13, 2024 08:52
@koivunej koivunej linked an issue May 13, 2024 that may be closed by this pull request
test: unable to run allowed_errors.py #7718
Closed
bayandin
bayandin approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

3060 tests run: 2927 passed, 0 failed, 133 skipped (full report)

Flaky tests (3)

Postgres 15

  • test_gc_aggressive: debug
  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

  • test_gc_aggressive: debug

Code coverage* (full report)

  • functions: 31.4% (6330 of 20161 functions)
  • lines: 47.3% (47753 of 100970 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
476dd57 at 2024-05-13T11:45:05.723Z :recycle:

bayandin
bayandin reviewed May 13, 2024
View reviewed changes
scripts/check_allowed_errors.bash Outdated Show resolved Hide resolved
scripts/check_allowed_errors.bash Outdated Show resolved Hide resolved
@koivunej koivunej enabled auto-merge (squash) May 13, 2024 10:59
@koivunej koivunej merged commit d9dcbff into main May 13, 2024
54 checks passed
@koivunej koivunej deleted the joonas/allow_using_allowed_errors branch May 13, 2024 12:16
a-masterov pushed a commit that referenced this pull request May 20, 2024
@koivunej @a-masterov
python: allow using allowed_errors.py (#7719)
b88beff 
See #7718. Fix it by renaming all `types.py` to `common_types.py`.

Additionally, add an advert for using `allowed_errors.py` to test any
added regex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bayandin bayandin bayandin approved these changes

@jcsp jcsp jcsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: unable to run allowed_errors.py
3 participants
@koivunej @bayandin @jcsp