Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build multi-arch images #7696

Merged
merged 3 commits into from May 22, 2024
Merged

CI: build multi-arch images #7696

merged 3 commits into from May 22, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented May 10, 2024

Problem

We don't build our docker images for ARM arch, and that makes it harder to run images on ARM (on MacBooks with Apple Silicon, for example).

Summary of changes

  • Build neondatabase/neon for ARM and create a multi-arch image
  • Build neondatabase/compute-node-vXX for ARM and create a multi-arch image
  • Run test-images job on ARM as well

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin added the run-e2e-tests-in-draft When placed on a PR, tells the CI to run e2e test in draft PR label May 10, 2024
Copy link

github-actions bot commented May 10, 2024

3078 tests run: 2951 passed, 0 failed, 127 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Code coverage* (full report)

  • functions: 31.4% (6412 of 20427 functions)
  • lines: 48.1% (49276 of 102532 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
de6bbe3 at 2024-05-21T12:39:27.659Z :recycle:

@bayandin bayandin force-pushed the bayadnin/multi-arch-images branch 3 times, most recently from 8c0d29d to e29b5b5 Compare May 15, 2024 12:00
@bayandin bayandin self-assigned this May 20, 2024
@bayandin
Copy link
Member Author

bayandin commented May 20, 2024

Last week:

  • it was implemented, but arm runners aren't reliable yet

This week:

  • Check if we have enough large-arm64 runners
  • Get PR merged

@bayandin bayandin force-pushed the bayadnin/multi-arch-images branch from e29b5b5 to 2bbd360 Compare May 20, 2024 13:43
@bayandin bayandin force-pushed the bayadnin/multi-arch-images branch from 2bbd360 to de6bbe3 Compare May 21, 2024 11:50
@bayandin bayandin marked this pull request as ready for review May 21, 2024 13:52
@bayandin bayandin requested a review from cicdteam May 21, 2024 13:53
@bayandin bayandin merged commit a7f31f1 into main May 22, 2024
70 checks passed
@bayandin bayandin deleted the bayadnin/multi-arch-images branch May 22, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e-tests-in-draft When placed on a PR, tells the CI to run e2e test in draft PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants