Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres 14.12, 15.7, and 16.3 updates #7688

Merged
merged 8 commits into from May 21, 2024
Merged

Conversation

tristan957
Copy link
Member

No description provided.

@tristan957 tristan957 requested a review from a team as a code owner May 10, 2024 05:45
@tristan957 tristan957 requested a review from skyzh May 10, 2024 05:45
@tristan957
Copy link
Member Author

@hlinnaka I didn't do the merge strategy because I think we should unsquash the v15 and v16 branches, though it seemed to work when I tried it out.

Copy link

github-actions bot commented May 10, 2024

3102 tests run: 2975 passed, 0 failed, 127 skipped (full report)


Flaky tests (5)

Postgres 16

  • test_secondary_background_downloads: debug

Postgres 15

  • test_hot_standby: debug
  • test_timeline_delete_resumed_on_attach: release
  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

  • test_secondary_background_downloads: debug

Code coverage* (full report)

  • functions: 31.3% (6383 of 20404 functions)
  • lines: 47.7% (48639 of 101920 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
98aba0a at 2024-05-20T16:41:33.682Z :recycle:

@skyzh skyzh requested review from hlinnaka and removed request for skyzh May 13, 2024 16:50
@tristan957 tristan957 force-pushed the tristan957/pg-updates branch 2 times, most recently from 39b2694 to 9f45419 Compare May 17, 2024 19:50
@tristan957 tristan957 requested a review from arssher May 17, 2024 19:51
@tristan957
Copy link
Member Author

FYI: neondatabase/postgres@3be8940

@tristan957 tristan957 force-pushed the tristan957/pg-updates branch 3 times, most recently from dc22fb8 to f457b90 Compare May 17, 2024 21:22
test_runner/regress/test_pg_regress.py Outdated Show resolved Hide resolved
test_runner/regress/test_pg_regress.py Outdated Show resolved Hide resolved
test_runner/regress/test_unlogged.py Outdated Show resolved Hide resolved
@tristan957 tristan957 force-pushed the tristan957/pg-updates branch 3 times, most recently from f8e989d to cb39039 Compare May 19, 2024 02:51
Copy link
Contributor

@hlinnaka hlinnaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the discussion at #7688 (comment), let's:

  • keep the test for an unlogged index, and
  • add an explicit test for an unlogged sequence.

With those changes, LGTM.

PS. Thanks for the very thorough comment on the history of unlogged sequences, that's very helpful!

@hlinnaka
Copy link
Contributor

hlinnaka commented May 19, 2024

Per the discussion at #7688 (comment), let's:

  • keep the test for an unlogged index, and

Tristan pointed on slack that that has been addressed.

  • add an explicit test for an unlogged sequence.

This would still be nice for clarity, but not essential. The test does cover unlogged sequences as it is

Some files may have known differences that we are okay with.
Previously we worked around file comparison issues by dropping unlogged
relations in the pg_regress tests, but this would lead to an unnecessary
diff when compared to upstream in our Postgres fork. Instead, we can
precompute the files that we know will be different, and ignore them.
Unlogged sequences were added in v15, so let's just test to make sure
they work on Neon.
@tristan957 tristan957 merged commit 1988ad8 into main May 21, 2024
56 checks passed
@tristan957 tristan957 deleted the tristan957/pg-updates branch May 21, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants