Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add version check for forward compat test #7685

Merged
merged 4 commits into from May 14, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 9, 2024

Problem

A test for #7684.

This pull request checks if the pageserver version we specified is the one actually running by comparing the git hash in forward compatibility tests.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh force-pushed the skyzh/test-forward-compat-binary-ver branch 3 times, most recently from 2a3075e to 95eec32 Compare May 9, 2024 18:46
@skyzh skyzh changed the title [DNM] add check for forward compat test [DNM] add version check for forward compat test May 9, 2024
Copy link

github-actions bot commented May 9, 2024

3060 tests run: 2927 passed, 0 failed, 133 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (6333 of 20168 functions)
  • lines: 47.3% (47832 of 101111 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2bbe2c8 at 2024-05-13T17:07:04.502Z :recycle:

@skyzh
Copy link
Member Author

skyzh commented May 9, 2024

main branch fails as expected:

2024-05-09T19:48:30.9828603Z FAILED test_runner/regress/test_compatibility.py::test_forward_compatibility[release-pg14]@compatibility - AssertionError: assert None
2024-05-09T19:48:30.9829128Z  +  where None = <bound method LogUtils.log_contains of <fixtures.neon_fixtures.NeonPageserver object at 0x7f4807226a00>>(('git-env:' + 'c4d7d5982553d2cf66634d1fbf85d95ef44a6524'))

https://github.com/neondatabase/neon/actions/runs/9022433795/job/24792429931

@skyzh skyzh changed the base branch from main to skyzh/fix-forward-compat-test May 9, 2024 19:50
@skyzh skyzh force-pushed the skyzh/test-forward-compat-binary-ver branch from af3c214 to 7ce3a3a Compare May 9, 2024 19:50
@skyzh skyzh changed the title [DNM] add version check for forward compat test chore(test): add version check for forward compat test May 9, 2024
@skyzh skyzh requested a review from bayandin May 9, 2024 19:51
Base automatically changed from skyzh/fix-forward-compat-test to main May 9, 2024 19:52
skyzh added 2 commits May 9, 2024 15:53
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/test-forward-compat-binary-ver branch from 7ce3a3a to df79d99 Compare May 9, 2024 19:53
@problame problame self-requested a review May 13, 2024 13:36
@skyzh
Copy link
Member Author

skyzh commented May 13, 2024

Ideally, we should also check Postgres version, but I don't think the compute node is printing git rev. And also due to a bug of how CI handles pg_distrib_dir, we are not using the correct Postgres version for forward compat test now.

Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the reservation to please add the requested assertion

test_runner/regress/test_compatibility.py Outdated Show resolved Hide resolved
skyzh added 2 commits May 13, 2024 12:17
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh merged commit 30d15ad into main May 14, 2024
55 checks passed
@skyzh skyzh deleted the skyzh/test-forward-compat-binary-ver branch May 14, 2024 14:36
a-masterov pushed a commit that referenced this pull request May 20, 2024
A test for #7684.

This pull request checks if the pageserver version we specified is the
one actually running by comparing the git hash in forward compatibility
tests.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants