-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): add version check for forward compat test #7685
Conversation
2a3075e
to
95eec32
Compare
3060 tests run: 2927 passed, 0 failed, 133 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
2bbe2c8 at 2024-05-13T17:07:04.502Z :recycle: |
main branch fails as expected:
https://github.com/neondatabase/neon/actions/runs/9022433795/job/24792429931 |
af3c214
to
7ce3a3a
Compare
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
7ce3a3a
to
df79d99
Compare
Ideally, we should also check Postgres version, but I don't think the compute node is printing git rev. And also due to a bug of how CI handles pg_distrib_dir, we are not using the correct Postgres version for forward compat test now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the reservation to please add the requested assertion
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
A test for #7684. This pull request checks if the pageserver version we specified is the one actually running by comparing the git hash in forward compatibility tests. --------- Signed-off-by: Alex Chi Z <chi@neon.tech>
Problem
A test for #7684.
This pull request checks if the pageserver version we specified is the one actually running by comparing the git hash in forward compatibility tests.
Summary of changes
Checklist before requesting a review
Checklist before merging