Update requirement.txt 2 #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqdm == 4.64.1 ## previously 4.46.0 ## 26Jan2023 changed to >= 4.64.1 # en-core-web-sm @ https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.3.0/ # 26Jan2023 commented out
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request focuses on updating dependencies within the requirements.txt file to ensure compatibility and leverage new features or bug fixes from the updated packages. Specifically, it updates the version of tqdm and comments out the en-core-web-sm model from spaCy, indicating a shift in dependency requirements or usage patterns.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that the updated version of tqdm does not introduce any breaking changes or incompatibilities with the current codebase. It's crucial to verify that all functionalities relying on tqdm still operate as expected after the update.
- Clarify the reason for commenting out the en-core-web-sm model. If this model is no longer required, consider removing it entirely from the requirements.txt to avoid confusion. If it's temporarily disabled, provide context in the PR description or comments within the requirements.txt file.
- The PR description template includes several unchecked items under the checklist section. It's important to complete these items or provide a rationale for any that are not applicable. This ensures that the PR is thoroughly vetted and meets the project's contribution guidelines.
- The 'Goal or purpose of the PR' section is left empty. Providing a brief description of the motivation behind the updates can help reviewers understand the context and rationale for the changes. This is especially important for dependency updates, as they can have wide-ranging impacts on the project.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tqdm == 4.64.1 ## previously 4.46.0 ## 26Jan2023 changed to >= 4.64.1
en-core-web-sm @ https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.3.0/ # 26Jan2023 commented out
To be able to merge a pull request, there are a few checks:
DO NOT DELETE THE BELOW TEXT FROM THE BODY OF THE PULL REQUEST. ADD YOUR DESCRIPTION(S) FROM THE POINT IT SAYS "Goal or purpose of the PR". USE THIS TEMPLATE AS IS.
USE THE CHECKLIST TO SHOW PROGRESS AND A REMINDER FOR YOURSELF.
Checklist
Please check the options that you have completed and strike-out the options that do not apply via this pull request:
./test-coverage.sh "tests slow-tests") - this will also be visible via the Code coverage report and CI/CD task on the Pull Requestnotebooksfolder, read the Notebooks docs)Goal or purpose of the PR
Changes implemented in the PR