Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #1091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix typo #1091

wants to merge 1 commit into from

Conversation

tursom
Copy link

@tursom tursom commented May 11, 2024

fix typo from OffsettDateTimeStringConverter to OffsetDateTimeStringConverter

@michael-simons
Copy link
Collaborator

Hi @tursom excellent catch, thanks a lot. But we cannot just change the name of public API.
The correct way is to deprecated the wrongly named class, introduce a copy of it with the fixed name and delete the deprecated in the next major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tursom @michael-simons