-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support native neo4j datetime type #530
base: master
Are you sure you want to change the base?
Conversation
Hello - thank you for your contribution. We are working on updating this repo and reviewing PRs but, to set expectations, maintenance is moving at a slow pace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yeus can you add a test for this? Take a look on test/test_properties.py
for examples. Sorry about the delay, and thanks for that!
- add unit test
will do! |
Can we work on a test for this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some tests
Made this little patch in order to support native neo4j datetime format https://neo4j.com/docs/api/python-driver/current/temporal_types.html#neo4j.time.DateTime.
here is the documentation about this format. I used some functions that don't appear in the official documentation. especially:
neo4j.to_native()
I also don't know the neomodel policy about where to import the neo4j library.