Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support native neo4j datetime type #530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support native neo4j datetime type #530

wants to merge 2 commits into from

Conversation

yeus
Copy link

@yeus yeus commented Nov 22, 2020

Made this little patch in order to support native neo4j datetime format https://neo4j.com/docs/api/python-driver/current/temporal_types.html#neo4j.time.DateTime.

here is the documentation about this format. I used some functions that don't appear in the official documentation. especially:

neo4j.to_native()

I also don't know the neomodel policy about where to import the neo4j library.

@whatSocks
Copy link
Collaborator

Hello - thank you for your contribution. We are working on updating this repo and reviewing PRs but, to set expectations, maintenance is moving at a slow pace.

Copy link
Contributor

@ficast ficast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeus can you add a test for this? Take a look on test/test_properties.py for examples. Sorry about the delay, and thanks for that!

  • add unit test

@yeus
Copy link
Author

yeus commented May 27, 2021

@yeus can you add a test for this? Take a look on test/test_properties.py for examples. Sorry about the delay, and thanks for that!

* [ ]  add unit test

will do!

@whatSocks whatSocks added this to Review in progress in Neomodel Maintenance Jun 24, 2021
@aanastasiou
Copy link
Collaborator

Hello @yeus , do you think that this could also potentially address #610 too?

@yeus
Copy link
Author

yeus commented Feb 17, 2023

Hello @yeus , do you think that this could also potentially address #610 too?

It kind of looks like that could be the case. to be sure I would test it though...

@mariusconjeaud
Copy link
Collaborator

Can we work on a test for this ?

Copy link
Collaborator

@mariusconjeaud mariusconjeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Neomodel Maintenance
Review in progress
Development

Successfully merging this pull request may close these issues.

None yet

5 participants