Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up node functions #1581

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Speed up node functions #1581

wants to merge 3 commits into from

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented Nov 8, 2019

Motivation and context:

Node functions have significant overhead, which can affect time-sensitive applications.

Interactions with other PRs:

Based on #1579. Note that this is currently rebased to a point farther back in master, because nengo-loihi is not yet working with master and I needed this with nengo-loihi.

How has this been tested?

I tested the speed improvements to a Loihi script using the parallel_ensemble.py benchmark in the private nengo-loihi-sandbox. I have not done any profiling in a general nengo script.

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Performance improvement

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

Previously, repeated `rc.get` calls could take significant time.
- Create optimized functions for running the python function,
  depending on inputs and outputs.
- Provide a read-only view for `x` instead of copying.
- The `check_output` config-system parameter allows output checking
  to be turned off (still on by default).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant