fix: Address the PHP 8.2 deprecations (#1158)

Follow up of #1157.
nelmio · Dec 2, 2023 · e98f2c4 · e98f2c4
1 parent 1141bf4
commit e98f2c4
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/fixtures/Definition/MethodCall/MutableMethodCall.php b/fixtures/Definition/MethodCall/MutableMethodCall.php
@@ -33,7 +33,7 @@ class MutableMethodCall implements MethodCallInterface
      */
     private $arguments;
 
-    public function __construct(?ServiceReferenceInterface $caller = null, $method, ?array $arguments = null)
+    public function __construct(?ServiceReferenceInterface $caller, $method, ?array $arguments = null)
     {
         $this->caller = $caller;
         $this->method = $method;

diff --git a/...Builder/Denormalizer/Fixture/SpecificationBagDenormalizer/Value/FakeValueDenormalizer.php b/...Builder/Denormalizer/Fixture/SpecificationBagDenormalizer/Value/FakeValueDenormalizer.php
@@ -22,7 +22,7 @@ class FakeValueDenormalizer implements ValueDenormalizerInterface
 {
     use NotCallableTrait;
 
-    public function denormalize(FixtureInterface $scope, ?FlagBag $flags = null, $value): void
+    public function denormalize(FixtureInterface $scope, ?FlagBag $flags, $value): void
     {
         $this->__call(__FUNCTION__, func_get_args());
     }

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -18,7 +18,7 @@
          executionOrder="random">
 
     <php>
-        <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=8"/>
+        <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0"/>
     </php>
 
     <listeners>

diff --git a/phpunit_symfony.xml.dist b/phpunit_symfony.xml.dist
@@ -19,7 +19,7 @@
 >
 
     <php>
-        <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=8" />
+        <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0" />
     </php>
 
     <listeners>

diff --git a/src/Definition/SpecificationBag.php b/src/Definition/SpecificationBag.php
@@ -34,7 +34,7 @@ final class SpecificationBag
      */
     private $calls;
 
-    public function __construct(?MethodCallInterface $constructor = null, PropertyBag $properties, MethodCallBag $calls)
+    public function __construct(?MethodCallInterface $constructor, PropertyBag $properties, MethodCallBag $calls)
     {
         $this->constructor = $constructor;
         $this->properties = $properties;

diff --git a/src/Generator/Resolver/ResolvingContext.php b/src/Generator/Resolver/ResolvingContext.php
@@ -37,7 +37,7 @@ public function __construct(?string $key = null)
      * Returns the existing instance if is an object or create a new one otherwise. It also ensure that the key will be
      * added also it won't increment the counter if already present.
      */
-    public static function createFrom(?self $resolving = null, string $key): self
+    public static function createFrom(?self $resolving, string $key): self
     {
         $instance = $resolving ?? new self();
         if (false === $instance->has($key)) {

diff --git a/tests/Generator/Resolver/Parameter/Chainable/ArrayParameterResolverTest.php b/tests/Generator/Resolver/Parameter/Chainable/ArrayParameterResolverTest.php
@@ -203,7 +203,7 @@ public function testIfResolutionResultsInMultipleParametersBeingResolvedThenThey
     /**
      * @dataProvider provideContexts
      */
-    public function testTheContextPassedToTheInjectedResolverIsAlwaysValid(?ResolvingContext $context = null, ResolvingContext $expected): void
+    public function testTheContextPassedToTheInjectedResolverIsAlwaysValid(?ResolvingContext $context, ResolvingContext $expected): void
     {
         $array = [
             $val1 = 'foo',