Update tests remove deprecations #2282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent zircotes deprecation messages
…s respected anyway)
|
Closing this because it got fixed in swagger-php zircote/swagger-php#1579 zircote/swagger-php#1586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to fix
DEPRECATION: Since zircote/swagger-php 4.9: Context detecting is deprecated zircote/swagger-php#1579
Because I don't know much about context handling, i am not sure if that fix is sufficient. Maybe there are some edge cases which I didnt consider.
Dependng on the outcome of te discussion at swagger-php mentioned above, this PR can be closed without merging.