This repository has been archived by the owner on Jul 10, 2020. It is now read-only.
Remove horizontal default behavior #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good improvement for the next release, but it breaks compatibility. Please can you update the readme file to explain this change. |
|
I'm waiting for your update of the README file to merge your pull request |
|
@neilime This PR would be useful. Can you update the README without to wait the author? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to remove the form-horizontal as default, since this is not the bootstrap default.
I'm having issues with this form-horizontal default behavior since this module isn't adding the required column ("col-xs-2", "col-xs-10") classes to label and the div that holds the element to properly space the horizontal style.
I guess it still needs update to make the form-horizontal behavior work properly and since the default one works out of the box, it makes much more sense to follow the same pattern bootstrap is doing.