Support custom seperator in param tag. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jens1o
commented
May 26, 2017
| @@ -161,8 +161,6 @@ export abstract class Block | |||
| */ | |||
| public getTypeFromValue(value:string):string | |||
| { | |||
| let result:Array<string>; | |||
There was a problem hiding this comment.
this isn't used in this method, that's why I deleted it.
|
@neild3r Could you review this, please? |
|
@neild3r I wonder whether you could take a look? |
|
The change in general seems OK but I don't know if the config name is the best description of the feature. Also shouldn't this apply to the return tag as well? |
Could you propose a name? I'm happy to hear how you'd describe that functionality.
Good point. |
|
I guess maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.