Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-deprecated lifecycle hooks #499

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

AmithBino
Copy link
Contributor

Description

Changed the deprecated lifecycle hooks. The "destroyed" lifecycle hook is deprecated, so changed to "unmounted".

bug fixes ##482 by @AmithBino

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Database change that requires a migration
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Local manual testing via "./manage runserver"
  • Local Python Unit Testing via "./manage test"
  • Local Cypress E2E Testing
  • Tested on virtual box
  • Tested on server

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@robotichead
Copy link
Collaborator

Thank you :D

@robotichead robotichead merged commit 99b344c into nearbeach:main Oct 3, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants