Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change nomination #146

Merged
merged 15 commits into from Dec 19, 2019
Merged

Change nomination #146

merged 15 commits into from Dec 19, 2019

Conversation

icerove
Copy link
Contributor

@icerove icerove commented Dec 12, 2019

fix the issue #134 but we should still wait ubtil nearcore and nearlib is okay to update

@render
Copy link

render bot commented Dec 12, 2019

Your Render PR Server URL is https://near-explorer-frontend-pr-146.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@render
Copy link

render bot commented Dec 12, 2019

A deploy for your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@render
Copy link

render bot commented Dec 14, 2019

A deploy for your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@render
Copy link

render bot commented Dec 14, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@icerove
Copy link
Contributor Author

icerove commented Dec 14, 2019 •
edited

this one fix the bug for fs in next and nearlib
vercel/next.js#7755

@render
Copy link

render bot commented Dec 14, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@render
Copy link

render bot commented Dec 17, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@icerove
Copy link
Contributor Author

icerove commented Dec 17, 2019 •
edited

image

after change, it will like this. I think it is still nearlib gives wrong method to shortcut the number. @kcole16

@render
Copy link

render bot commented Dec 17, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@render
Copy link

render bot commented Dec 17, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@render
Copy link

render bot commented Dec 17, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

frol
frol requested changes Dec 17, 2019
View reviewed changes
frontend/src/components/transactions/__tests__/__snapshots__/ActionMessage.test.tsx.snap Outdated Show resolved Hide resolved
frontend/src/components/utils/Balance.jsx Outdated Show resolved Hide resolved
frontend/next.config.js
Comment on lines +39 to +45
webpack: (config, { isServer }) => {
// Fixes npm packages that depend on `fs` module
if (!isServer) {
config.node = {
fs: "empty"
};
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something wrong with nearlib? Do we have an issue there? Can we fix it there? /cc @janedegtiareva

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vercel/next.js#7755 the issue and method is here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vlad and I talked about this and this definitely can fix in the nearlib, nearlib does not fit browser configuration and webpack maybe a good method to do with that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a tracking issue on nearlib and put a link to the issue in a comment here.

@icerove icerove requested a review from frol December 17, 2019 20:26
@icerove
Copy link
Contributor Author

icerove commented Dec 17, 2019

find out the test is okay just because testnet is down yesterday. If nearlib is not changing anymore, this version for explorer is ready to go.
@frol I know maybe this is not okey for you, but the changes should happen on nearlib side

frol
frol requested changes Dec 18, 2019
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like not to regress on the "<0.00001 N" display. Other than everything is fine.

@kcole16 kcole16 mentioned this pull request Dec 18, 2019
Closed
2 tasks
@kcole16
Copy link
Contributor

kcole16 commented Dec 18, 2019

I would like not to regress on the "<0.00001 N" display. Other than everything is fine.

I created a separate issue to encapsulate this #152 (and put it as highest priority), as we're proceeding with yoctoNEAR rollout currently.

@render
Copy link

render bot commented Dec 18, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@render
Copy link

render bot commented Dec 18, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@render
Copy link

render bot commented Dec 18, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@render
Copy link

render bot commented Dec 18, 2019

Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg.

@icerove icerove merged commit b6b3f5f into master Dec 19, 2019
@icerove icerove deleted the change-nomination branch April 9, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgrichina vgrichina vgrichina left review comments

@frol frol frol approved these changes

@janedegtiareva janedegtiareva Awaiting requested review from janedegtiareva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@icerove @kcole16 @vgrichina @frol